[NSFS] Fix list objects ordering to follow AWS S3 #8324
+253
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangledbytes
force-pushed
the
utkarsh/fix/list-objects-order
branch
2 times, most recently
from
dea5a53
to
e2f82c8
Compare
tangledbytes
force-pushed
the
utkarsh/fix/list-objects-order
branch
from
e2f82c8
to
0f7adb7
Compare
2 tasks
tangledbytes
force-pushed
the
utkarsh/fix/list-objects-order
branch
from
0f7adb7
to
1d9f7de
Compare
Signed-off-by: Utkarsh Srivastava <[email protected]> add more tests for asserting the correctness of utf8 sorting Signed-off-by: Utkarsh Srivastava <[email protected]> fix order when markers are involved Signed-off-by: Utkarsh Srivastava <[email protected]> add caching for name buffers - lifetime limited to per invocation of list_objects Signed-off-by: Utkarsh Srivastava <[email protected]>
tangledbytes
force-pushed
the
utkarsh/fix/list-objects-order
branch
from
1d9f7de
to
b19d5ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR replaces the pre-existing sorting functions in listObjects (NSFS) with a new one which tries to treat strings as UTF8 encoded Uint8Arrays. This helps with sorting the array of strings in a similar fashion as AWS S3 does.
Issues: Fixed #xxx / Gap #xxx
Fixes #8218
Testing Instructions:
./node_modules/.bin/mocha src/test/unit_tests/test_namespace_fs.js./node_modules/.bin/jest src/test/unit_tests/jest_tests/js_utils.test.js